zeroshade commented on code in PR #669:
URL: https://github.com/apache/arrow-go/pull/669#discussion_r2833990261


##########
arrow/ipc/testdata/custom_metadata_stream.arrows:
##########


Review Comment:
   Do we not have any tests in arrow-testing which use the custom metadata 
features?



##########
arrow/array/record.go:
##########
@@ -121,6 +121,7 @@ type simpleRecord struct {
        refCount atomic.Int64
 
        schema *arrow.Schema
+       meta   arrow.Metadata

Review Comment:
   is there any reason to not incorporate this extra metadata into the schema 
itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to