liamzwbao commented on PR #9437: URL: https://github.com/apache/arrow-rs/pull/9437#issuecomment-3936846943
> Seems reasonable, but would it make sense to actually use it in the JSON writer while we're at it? It's not dead code tho -- variant still uses it -- so this is largely a matter of preference and sequencing that would likely depend on how big the JSON change is. > > I believe there's also a `StringLikeArray` trait -- should we give it the same treatment (not necessarily in this PR)? I'm going to create a PR for json list encoder/decoder, and this change will help reduce duplication there. I kept it separate so we don’t need to review both changes at once, and can instead focus on the JSON logic in that upcoming PR. Re `StringLikeArray`, we don’t have such a trait, but we do have a `StringLikeArrayBuilder` in `arrow-array` that’s already used by `parquet-variant`. This PR simply mirrors that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
