rok commented on code in PR #38008:
URL: https://github.com/apache/arrow/pull/38008#discussion_r2835146701
##########
cpp/src/arrow/extension/tensor_internal.h:
##########
@@ -20,25 +20,17 @@
#include <cstdint>
#include <vector>
-#include "arrow/status.h"
-#include "arrow/util/print_internal.h"
+#include "arrow/array/array_nested.h"
namespace arrow::internal {
-inline Status IsPermutationValid(const std::vector<int64_t>& permutation) {
- const auto size = static_cast<int64_t>(permutation.size());
- std::vector<uint8_t> dim_seen(size, 0);
+ARROW_EXPORT
+Status IsPermutationValid(const std::vector<int64_t>& permutation);
- for (const auto p : permutation) {
- if (p < 0 || p >= size || dim_seen[p] != 0) {
- return Status::Invalid(
- "Permutation indices for ", size,
- " dimensional tensors must be unique and within [0, ", size - 1,
- "] range. Got: ", ::arrow::internal::PrintVector{permutation, ","});
- }
- dim_seen[p] = 1;
- }
- return Status::OK();
-}
+ARROW_EXPORT
+Status ComputeStrides(const std::shared_ptr<DataType>& value_type,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
