lidavidm commented on code in PR #4009: URL: https://github.com/apache/arrow-adbc/pull/4009#discussion_r2835958911
########## .gitignore: ########## @@ -83,6 +83,9 @@ local/ site/ +# Design plans +docs/plans/ + Review Comment: What is this from? ########## go/adbc/adbc.test: ########## Review Comment: This shouldn't be checked in. ########## go/adbc/adbc.go: ########## @@ -33,6 +33,18 @@ // safely from multiple goroutines, but not necessarily concurrent // access. Specific implementations may allow concurrent access. // +// # Context Support +// +// As of ADBC API revision 1.2.0, context-aware interfaces are available: Review Comment: TBH, I don't think this needs to be tied to an API revision. We can just add this as an API improvement. ########## go/adbc/adbc.go: ########## Review Comment: There's `DriverWithContext` in ext.go. Should we keep naming consistent? Should we move it from ext.go to adbc.go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
