paleolimbot commented on code in PR #3872:
URL: https://github.com/apache/arrow-adbc/pull/3872#discussion_r2838265633
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -1612,6 +1627,24 @@ ADBC_EXPORT
AdbcStatusCode AdbcConnectionRelease(struct AdbcConnection* connection,
struct AdbcError* error);
+/// \brief Set a warning handler.
+///
+/// May be set before or after AdbcConnectionInit.
+///
+/// \since ADBC API revision 1.2.0
Review Comment:
> My ideal for something like a lossy conversion might be to warn about it
the first time and then to report it at the end as a statistical summary e.g.
"there were 3065 lossy conversions in this result".
👍
> I have a slight preference for this specific case to put serialization /
concurrency safety onto the consumer
That makes sense. As a host application you might want to be defensive
anyway. In R we have to call `Rf_warning()` from a very specific thread and so
just serializing the calls won't help anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
