veeceey commented on PR #49373: URL: https://github.com/apache/arrow/pull/49373#issuecomment-3942479910
### Test Results Code structure verified - braces balanced, visitor correctly added. The C++ build requires cmake setup which I don't have locally, but the implementation follows the exact same patterns as the existing `VisitBaseBinary` handler. The visitor handles: - Validity bitmap via `VisitBitmap()` - Views buffer as fixed-width (16 bytes per view) - Out-of-line data buffers with min/max offset tracking per buffer index Added test cases: - `BinaryViewInline`: all-inline strings (no data buffers) - `StringViewInline`: string_view (inherits BinaryViewType) - `BinaryViewOutOfLine`: strings >12 bytes stored out-of-line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
