Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2839635802
##########
cpp/src/arrow/compute/kernels/vector_select_k.cc:
##########
@@ -74,6 +74,120 @@ class SelectKComparator<SortOrder::Descending> {
}
};
+struct ExtractCounter {
Review Comment:
I added comments in the refactored implementation. I also made extensive use
of `std::span`, which I have found lead to clearer code in this implementation.
Let me know what you think! I can also revert to more explicit iterators if
desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
