jonkeane commented on PR #49370:
URL: https://github.com/apache/arrow/pull/49370#issuecomment-3945018608

   This is something that showed up on CRAN: the red M1Mac on 
https://cran.r-project.org/web/checks/check_results_arrow.html. 
   
   ```
   -- CMAKE_CXX_FLAGS_RELEASE: -O3 -DNDEBUG -O2 
   CMake Error at cmake_modules/BuildUtils.cmake:114 (message):
     libtool found appears not to be Apple's libtool: /usr/bin/libtool
   ```
   
   And then separately I also received this from one of the CRAN maintainers: 
   
   ```
   /usr/bin/libtool -V
   Apple Inc. version cctools_ld-1266.5
   ```
   
   The whole reason for this detection issue is because some CRAN machines had 
GNU `libtool` (an _entirely different tool_  higher on their path than the 
apple-provided `libtool` that does the linking we want/need see #40259). So we 
sniffed for a string that could tell the difference. I'm not sure why on this 
machine (suddenly! nothing in our code here has changed since 2024...) the 
version string is slightly different, but this new regex is a bit more 
flexible. 
   
   We test this in crossbow jobs installing macos locally 
https://github.com/ursacomputing/crossbow/actions/runs/22282130627/job/64454329380#step:9:790
 which we setup to use GNU `libtool` specially: 
https://github.com/ursacomputing/crossbow/actions/runs/22282130627/job/64454329380#step:6:2
 though that runner has the standard (apple) `libtool` version string that we 
detect just fine with our stricter regex.
   
   I am also going to add a print if I can to the cmake to also print out the 
version string we get when it errors so that we didn't need one of the CRAN 
maintainers to send us the string.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to