sdf-jkl commented on PR #9457: URL: https://github.com/apache/arrow-rs/pull/9457#issuecomment-3946968571
> Main question in my mind: Is this like binary, where we need to force everything to a preferred list type that downstream variant code requires? Or just a few missing match arms? I _think_ it's the latter, but I don't see any tests in this PR that give evidence in either direction? It is the latter. I didn't add any tests because I didn't see any for other types, including originally supported List. Other types seem to be covered by existing [integration tests suite](https://github.com/apache/arrow-rs/blob/main/parquet/tests/variant_integration.rs), but it shouldn't cover other List-like types cases. I'll add some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
