lidavidm commented on code in PR #4008: URL: https://github.com/apache/arrow-adbc/pull/4008#discussion_r2843507726
########## c/include/arrow-adbc/adbc.h: ########## @@ -1766,20 +1852,56 @@ AdbcStatusCode AdbcConnectionGetInfo(struct AdbcConnection* connection, /// | constraint_type | utf8 not null | (1) | /// | constraint_column_names | list<utf8> not null | (2) | /// | constraint_column_usage | list<USAGE_SCHEMA> | (3) | -/// -/// 1. One of 'CHECK', 'FOREIGN KEY', 'PRIMARY KEY', or 'UNIQUE'. +/// | constraint_expression | utf8 | (4) | +/// | constraint_update_rule | int16 | (5) | +/// | constraint_delete_rule | int16 | (5) | +/// | constraint_enforced | bool | (6) | +/// | constraint_deferrability | int16 | (7) | +/// | constraint_match_type | int16 | (8) | +/// +/// 1. One of 'CHECK', 'FOREIGN KEY', 'PRIMARY KEY', or 'UNIQUE', or a +/// vendor-specific type. /// 2. The columns on the current table that are constrained, in /// order. /// 3. For FOREIGN KEY only, the referenced table and columns. +/// 4. [Since version 1.2.0] The vendor-specific definition of the constraint +/// (e.g. the SQL expression to be checked). This field is optional. +/// 5. [Since version 1.2.0] The action to be taken when the primary key is +/// updated or deleted. The value is one of the ADBC_CONSTRAINT_ACTION_ +/// constants. This field is optional. +/// 6. [Since version 1.2.0] Whether the constraint is currently enabled. +/// This field is optional. +/// 7. [Since version 1.2.0] Whether the constraint can be deferred, and if +/// so, whether it starts deferred. The value is one of the +/// ADBC_CONSTRAINT_DEFERRABLE_ constants or +/// ADBC_CONSTRAINT_NOT_DEFERRABLE. This field is optional. +/// 8. [Since version 1.2.0] How the foreign key constraint should be matched. +/// The value is one of the ADBC_CONSTRAINT_MATCH_ constants. This field +/// is optional. /// /// USAGE_SCHEMA is a Struct with fields: /// -/// | Field Name | Field Type | -/// |--------------------------|-------------------------| -/// | fk_catalog | utf8 | -/// | fk_db_schema | utf8 | -/// | fk_table | utf8 not null | -/// | fk_column_name | utf8 not null | +/// | Field Name | Field Type | Comments | +/// |--------------------------|-------------------------|----------| +/// | fk_catalog | utf8 | | +/// | fk_db_schema | utf8 | | +/// | fk_table | utf8 not null | | +/// | fk_column_name | utf8 not null | | +/// | fk_key_seq | int32 not null | (1) | +/// | fk_pk_name | utf8 | (2) | Review Comment: Sorry, how are they dependent on each other? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
