abonander commented on code in PR #3905:
URL: https://github.com/apache/arrow-adbc/pull/3905#discussion_r2848968066


##########
rust/core/src/sync.rs:
##########
@@ -44,6 +44,24 @@ pub trait Optionable {
     fn get_option_double(&self, key: Self::Option) -> Result<f64>;
 }
 
+/// A handle to cancel an in-progress operation on a connection.
+///
+/// This is a separated handle because otherwise it would be impossible to
+/// call a `cancel` method on a connection or statement itself.
+pub trait CancelHandle: Send {
+    /// Cancel the in-progress operation on a connection.
+    fn try_cancel(&self) -> Result<()>;

Review Comment:
   It's only sort-of implied by 
https://github.com/apache/arrow-adbc/blob/e8642f824393a99d4a2ac3cde89f15b10e7f3101/c/include/arrow-adbc/adbc.h#L2130-L2131



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to