kou commented on code in PR #48886:
URL: https://github.com/apache/arrow/pull/48886#discussion_r2850354870
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -550,8 +546,6 @@ def github_overwrite_release_assets(self, tag_name,
target_commitish,
patterns, method='requests'):
# Since github has changed something the asset uploading via requests
# got instable, so prefer the cURL alternative.
- # Potential cause:
- # sigmavirus24/github3.py/issues/779#issuecomment-379470626
Review Comment:
Can we remove curl fallback with PyGithub?
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -448,49 +448,48 @@ def file_contents(self, commit_id, file):
blob = self.repo[entry.id]
return blob.data
- def _github_login(self, github_token):
- """Returns a logged in github3.GitHub instance"""
- if not _have_github3:
- raise ImportError('Must install github3.py')
+ def _github_login(self, github_token=None):
+ """Returns a logged in Github instance using PyGithub"""
+ if not _have_github:
+ raise ImportError('Must install PyGithub')
github_token = github_token or self.github_token
- session = github3.session.GitHubSession(
- default_connect_timeout=10,
- default_read_timeout=30
- )
- github = github3.GitHub(session=session)
- github.login(token=github_token)
- return github
+ return Github(auth=GithubAuth.Token(github_token), timeout=30)
def as_github_repo(self, github_token=None):
"""Converts it to a repository object which wraps the GitHub API"""
if self._github_repo is None:
github = self._github_login(github_token)
username, reponame = _parse_github_user_repo(self.remote_url)
- self._github_repo = github.repository(username, reponame)
+ self._github_repo = github.get_repo(f"{username}/{reponame}")
return self._github_repo
def token_expiration_date(self, github_token=None):
"""Returns the expiration date for the github_token provided"""
github = self._github_login(github_token)
- # github3 hides the headers from us. Use the _get method
- # to access the response headers.
- resp = github._get(github.session.base_url)
- # Response in the form '2023-01-23 10:40:28 UTC'
- date_string = resp.headers.get(
- 'github-authentication-token-expiration')
+ # NOTE: We access the private _Github__requester to get response
+ # headers, as PyGithub doesn't expose the token expiration header
+ # through its public API. This may break with future PyGithub updates.
Review Comment:
Could you open an issue to PyGithub to add a public API for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
