andishgar commented on code in PR #49290:
URL: https://github.com/apache/arrow/pull/49290#discussion_r2854236046
##########
cpp/src/arrow/testing/math.h:
##########
@@ -23,17 +23,17 @@
namespace arrow {
ARROW_TESTING_EXPORT
-bool WithinUlp(util::Float16 left, util::Float16 right, int n_ulps);
+bool WithinUlp(util::Float16 left, util::Float16 right, uint16_t n_ulps);
ARROW_TESTING_EXPORT
-bool WithinUlp(float left, float right, int n_ulps);
+bool WithinUlp(float left, float right, uint16_t n_ulps);
ARROW_TESTING_EXPORT
-bool WithinUlp(double left, double right, int n_ulps);
+bool WithinUlp(double left, double right, uint16_t n_ulps);
Review Comment:
No, it’s okay. I just wanted to keep it compatible. I removed the APIs in
the tests and unified them through arrow::EqualOptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
