Alvaro-Kothe commented on PR #49403:
URL: https://github.com/apache/arrow/pull/49403#issuecomment-3970280405
Most of the CI errors are due to compiler warnings in c_glib due to the
deprecations in `statistics.h`. Before diving deeper into fixing them, I'd like
to ask for guidance on three points:
1. Should I proceed with the deprecation of these methods, should I
remove them directly, or is there a better way to handle this migration?
2. I removed several public attributes and changed the type to some of
them. Should I re-add these as deprecated members to maintain backward
compatibility, or is the migration to `std::optional` sufficient?
3. The
[`Statistics`](https://github.com/apache/arrow/blob/a0c9a4b9dca6a297d2486e9f81ed79534cbb6a27/cpp/src/generated/parquet_types.h#L713)
class in `parquest_types.h` also uses a similar mechanism of boolean flags to
keep track of what is defined. Should I also migrate it to use `std::optional`?
cc: @pitrou @felipecrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
