brunal commented on issue #9490: URL: https://github.com/apache/arrow-rs/issues/9490#issuecomment-3976616021
Sorry I'm a bit late to the party -- why does `from_naive_datetime` accept a timezone? As that makes it a proper datetime. What's the point of accepting `from_naive_datetime(dt, Some(tz))` instead of making the user call `tz.from_local_datetime(&dt)` + handle ambiguosity themselves? Then you'd get proper orthogonal API endpoints. Right now the sensible case for `from_naive_datetime` is NOT to pass a tz, and one ends up passing an unclear `None` arg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
