kentkwu commented on PR #390:
URL: https://github.com/apache/arrow-js/pull/390#issuecomment-3977312643

   > Could you check the generated docs (the `release-docs` artifact in 
https://github.com/apache/arrow-js/actions/runs/22507469873?pr=390) whether the 
result is expected or not?
   
   Confirmed that Field and Schema now show up correctly.
   
   Before:
   
   ```sh
   ❯ curl -s https://arrow.apache.org/js/current/modules/Arrow.dom.html \
     | grep -o 'classes/Arrow\.dom\.[^"]*\.html' | sort -u
   
   classes/Arrow.dom.Builder.html
   classes/Arrow.dom.Data.html
   classes/Arrow.dom.DataType.html
   classes/Arrow.dom.MapRow.html
   classes/Arrow.dom.RecordBatchReader.html
   classes/Arrow.dom.RecordBatchWriter.html
   classes/Arrow.dom.StructRow.html
   classes/Arrow.dom.Table.html
   classes/Arrow.dom.Vector.html
   classes/Arrow.dom.Visitor.html
   ```
   
   After:
   ```sh
   ❯ gh run download 22507469873 --repo apache/arrow-js --name release-docs 
--dir /tmp/verify-docs \
   && tar tf /tmp/verify-docs/apache-arrow-js-docs-21.1.0.tar.gz | grep 
"classes/" | sed 's|[^/]*/||' | sort
   classes/
   classes/Arrow.dom.Builder.html
   classes/Arrow.dom.Data.html
   classes/Arrow.dom.DataType.html
   classes/Arrow.dom.Field.html
   classes/Arrow.dom.MapRow.html
   classes/Arrow.dom.RecordBatchReader.html
   classes/Arrow.dom.RecordBatchWriter.html
   classes/Arrow.dom.Schema.html
   classes/Arrow.dom.StructRow.html
   classes/Arrow.dom.Table.html
   classes/Arrow.dom.Vector.html
   classes/Arrow.dom.Visitor.html
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to