brunal commented on PR #9454:
URL: https://github.com/apache/arrow-rs/pull/9454#issuecomment-3980554059
Going over the change once again, if we avoid unnecessary recursive calls,
then the complex uses of `downcast_primitive_array!` work fine with
rust-analyzer. The original issue was that `(foo, bar) => thing()` was being
turned into `foo, bar => { thing() }`, then into `(foo, bar) => { thing() }`,
and then into the base case.
As such, I'm removing the tt muncher arms and restoring the descriptive arms
(with bonus comments explaining the fixups), removing the need for usage
comments. LMK what you think.
In recap, the changes now:
* for all macros:
* reduce quantifiers
* for recursive macros:
* limit recursive calls
* put the base case first
* avoid wrapping in parentheses just to remove them later on. Note: that's
debatable as the base case now shows the inelegant unwrapped `$values` list.
* add some comments on the fixups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
