lidavidm commented on a change in pull request #10224:
URL: https://github.com/apache/arrow/pull/10224#discussion_r625176491



##########
File path: python/pyarrow/dataset.py
##########
@@ -733,19 +733,17 @@ def write_dataset(data, base_dir, basename_template=None, 
format=None,
     """
     from pyarrow.fs import _resolve_filesystem_and_path
 
-    if isinstance(data, Dataset):
-        schema = schema or data.schema

Review comment:
       Yeah, either accepting a schema for a projection or having a separate 
schema keyword would be a nice convenience if all you want to do is select/cast 
columns.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to