paleolimbot commented on code in PR #4029:
URL: https://github.com/apache/arrow-adbc/pull/4029#discussion_r2870229564
##########
ci/scripts/run_cgo_drivermgr_check.sh:
##########
@@ -32,15 +32,15 @@ main() {
for f in "$@"; do
fn=$(basename $f)
- if [[ "$fn" == "adbc_driver_manager.cc" ]]; then
- if ! diff -q "$f" "go/adbc/drivermgr/$fn" &>/dev/null; then
- >&2 echo "OUT OF SYNC: $f differs from go/adbc/drivermgr/$fn"
+ if [[ "$fn" == "adbc.h" || "$fn" == "adbc_driver_manager.h" ]]; then
+ if ! diff -q "$f" "go/adbc/drivermgr/arrow-adbc/$fn" &>/dev/null; then
+ >&2 echo "OUT OF SYNC: $f differs from
go/adbc/drivermgr/arrow-adbc/$fn"
Review Comment:
While you're here it might be nice to have this error include how to fix it
(e.g., `cp c/whatever/adbc_driver_manager*.cc go/adbc/drivermgr/arrow-adbc/`,
or maybe there's a script for this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
