Tom-Newton commented on code in PR #49140:
URL: https://github.com/apache/arrow/pull/49140#discussion_r2871406088
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -247,13 +247,17 @@ Result<AzureOptions> AzureOptions::FromUri(const
std::string& uri_string,
}
bool AzureOptions::Equals(const AzureOptions& other) const {
- const bool equals = blob_storage_authority == other.blob_storage_authority &&
- dfs_storage_authority == other.dfs_storage_authority &&
- blob_storage_scheme == other.blob_storage_scheme &&
- dfs_storage_scheme == other.dfs_storage_scheme &&
- default_metadata == other.default_metadata &&
- account_name == other.account_name &&
- credential_kind_ == other.credential_kind_;
+ const bool equals =
+ account_name == other.account_name &&
+ blob_storage_authority == other.blob_storage_authority &&
+ dfs_storage_authority == other.dfs_storage_authority &&
+ blob_storage_scheme == other.blob_storage_scheme &&
+ dfs_storage_scheme == other.dfs_storage_scheme &&
+ default_metadata == other.default_metadata &&
+ background_writes == other.background_writes &&
+ credential_kind_ == other.credential_kind_ && account_key_ ==
other.account_key_ &&
Review Comment:
I should have payed more attention to that myself. I think its happy again
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
