gruuya commented on PR #9421: URL: https://github.com/apache/arrow-rs/pull/9421#issuecomment-3989717753
> Before we merge tho, we should verify that there's consensus that the current behavior is a bug -- I didn't see any comments on the bug report. I think this makes sense to fix. I've been thinking about a potential solution that would solve not only this, but also https://github.com/apache/arrow-rs/issues/5762, as well as avoid the double pass that sometimes occurs in `parse_e_notation`. This solution would perform a single backwards pass (the alternative mentioned here https://github.com/apache/arrow-rs/issues/9170) instead of a forwards pass on the input string, which means that - if present, we parse e-notation first - then we know whether we should include more or less of the fractionals for a given scale - we should be able to avoid the overflow with negative e-notation - we should be able to round appropriately I still need to think about it a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
