hhhizzz commented on code in PR #9474:
URL: https://github.com/apache/arrow-rs/pull/9474#discussion_r2881367064
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -688,13 +688,20 @@ fn override_selector_strategy_if_needed(
projection_mask: &ProjectionMask,
offset_index: Option<&[OffsetIndexMetaData]>,
) -> ReadPlanBuilder {
- // override only applies to Auto policy, If the policy is already Mask or
Selectors, respect that
- let RowSelectionPolicy::Auto { .. } = plan_builder.row_selection_policy()
else {
+ // If the policy is already Selectors, no override is needed
Review Comment:
I remember our design here is to respect the user’s configuration. If they
choose `mask`, they should face the risk that the program may fail, rather than
the program implicitly changing the setting to `selector`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
