Rafferty97 commented on code in PR #9496: URL: https://github.com/apache/arrow-rs/pull/9496#discussion_r2881728120
########## arrow-json/src/reader/mod.rs: ########## @@ -181,12 +181,14 @@ mod tape; mod timestamp_array; /// A builder for [`Reader`] and [`Decoder`] +#[derive(Clone)] Review Comment: I clone the `ReaderBuilder` in `do_read_config`, which was the most straightforward way of allowing tests to pass in additional config. Otherwise I woud've has to add an `impl Fn() -> ReaderBuilder` which seemed more convoluted than just having `ReaderBuilder` implement `Clone`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
