kentkwu opened a new pull request, #405:
URL: https://github.com/apache/arrow-js/pull/405

   ## What's Changed
   
   Applies a fix for type inference crashing on encountering an array of 
strings.
   
   Added a `compareTypesForInference` helper that compares Dictionary types 
structurally, ignoring IDs. It recurses through List and Struct for nested 
cases. The public compareTypes is unchanged. ID equality still matters for IPC 
comparisons.
   
   
   **Root cause:**
   
   Strings infer to Dictionary<Utf8, Int32>, and every Dictionary construction 
auto-increments a global ID. The array homogeneity check in inferType calls 
compareTypes on separately inferred types, which requires matching IDs — so it 
always fails for string arrays.
   
   Closes #86, #50
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to