scovich commented on code in PR #9505:
URL: https://github.com/apache/arrow-rs/pull/9505#discussion_r2887398116
##########
arrow-row/src/lib.rs:
##########
@@ -1415,7 +1415,7 @@ impl DoubleEndedIterator for RowsIter<'_> {
return None;
}
// Safety: We have checked that `start` is less than `end`
- let row = unsafe { self.rows.row_unchecked(self.end) };
+ let row = unsafe { self.rows.row_unchecked(self.end - 1) };
self.end -= 1;
Review Comment:
Should we just move the `self.end` decrement above the original `unsafe`
block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
