junyan-ling commented on code in PR #689:
URL: https://github.com/apache/arrow-go/pull/689#discussion_r2892513908
##########
parquet/file/record_reader.go:
##########
@@ -758,6 +766,8 @@ func (fr *flbaRecordReader) GetBuilderChunks()
[]arrow.Array {
func (fr *flbaRecordReader) ReadDictionary() bool { return false }
+func (fr *flbaRecordReader) ReserveData(int64) {}
Review Comment:
`FixedSizeBinaryBuilder` doesn't have a variable-length data buffer, since
all values are the same width, the buffer size is fully determined by the slot
count, which `ReserveValues` already handles via `bldr.Reserve(n)`.
`ReserveData` is only meaningful for `byteArrayRecordReader` where value
lengths vary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
