jorisvandenbossche commented on code in PR #49259:
URL: https://github.com/apache/arrow/pull/49259#discussion_r2894465318
##########
docs/source/developers/python/building.rst:
##########
@@ -576,12 +572,22 @@ PyArrow are:
* - ``PYARROW_BUNDLE_CYTHON_CPP``
- Bundle the C++ files generated by Cython
- ``0`` (``OFF``)
- * - ``PYARROW_BUILD_VERBOSE``
- - Enable verbose output from Makefile builds
- - ``0`` (``OFF``)
- * - ``PYARROW_PARALLEL``
- - Number of processes used to compile PyArrow’s C++/Cython components
- - ``''``
+
+To set the build type (e.g. ``Debug``, ``Release``, ``RelWithDebInfo``), pass
+``-C cmake.build-type=Debug`` to ``pip install`` or to ``python -m build``.
+
+For extra CMake arguments you can use the ``-C cmake.args=``
+argument when building PyArrow. For example, to build a version of PyArrow
+with ``ARROW_SIMD_LEVEL=NONE``, you can run
+``pip install --no-build-isolation -vv -C cmake.args="-DARROW_SIMD_LEVEL=NONE"
.``.
Review Comment:
I don't know for how many people it would be useful, but I think for people
that are currently using the env variables like `PYARROW_CMAKE_OPTIONS` (as we
were doing ourselves), it might be useful to keep a mention of this "old way"
explaining how to update.
##########
docs/source/developers/python/building.rst:
##########
Review Comment:
(not related to the changes here, but noticed while reviewing: I suppose
this is the wrong ref link, should it be `stale_artifacts` instead?
##########
python/setup.py:
##########
@@ -1,483 +0,0 @@
-#!/usr/bin/env python
-
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-import contextlib
-import os
-import os.path
-from os.path import join as pjoin
-import re
-import shlex
-import shutil
-import sys
-import warnings
-
-if sys.version_info >= (3, 10):
- import sysconfig
-else:
- # Get correct EXT_SUFFIX on Windows (https://bugs.python.org/issue39825)
- from distutils import sysconfig
-
-from setuptools import setup, Extension, Distribution
-from setuptools.command.sdist import sdist
-
-from Cython.Distutils import build_ext as _build_ext
-import Cython
-
-# Check if we're running 64-bit Python
-is_64_bit = sys.maxsize > 2**32
-
-# We can't use sys.platform in a cross-compiling situation
-# as here it may be set to the host not target platform
-is_emscripten = (
- sysconfig.get_config_var("SOABI")
- and sysconfig.get_config_var("SOABI").find("emscripten") != -1
-)
-
-
-if Cython.__version__ < '3.1':
- raise Exception(
- 'Please update your Cython version. Supported Cython >= 3.1')
Review Comment:
Do we want to keep a check for this? (cmake knows the cython version, so in
theory we could check there, not sure how important this is)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
