eddelbuettel commented on issue #850:
URL:
https://github.com/apache/arrow-nanoarrow/issues/850#issuecomment-4011968632
Thanks for the fix. I don't even think you need these two variables; the
all-encompassing `-Wall` should do. It does here. Even when I shrink my
`~/.R/Makevars` down and removed `-pedantic` and one or two extra flags `R CMD
check` lets me have without bitching I use e.g.
```sh
ccache gcc-15 -std=gnu2x -I"/usr/share/R/include" -DNDEBUG -I../inst/include
-I../src \
-DFLATCC_USE_GENERIC_ALIGNED_ALLOC -DNANOARROW_IPC_WITH_ZSTD \
-fpic -O3 -Wall -pipe -c nanoarrow_ipc.c -o nanoarrow_ipc.o
```
then all hell still breaks loose on the CRAN version but no longer on your
updated branch. So big thanks for merging this 'soon'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
