pitrou commented on code in PR #49304:
URL: https://github.com/apache/arrow/pull/49304#discussion_r2910682511
##########
cpp/src/arrow/compute/kernels/vector_rank.cc:
##########
@@ -38,8 +38,9 @@ namespace {
// is the same as the value at the previous sort index.
constexpr uint64_t kDuplicateMask = 1ULL << 63;
-template <typename ValueSelector>
-void MarkDuplicates(const NullPartitionResult& sorted, ValueSelector&&
value_selector) {
+template <typename ArrowType, typename ValueSelector, typename IsNullSelector>
+void MarkDuplicates(const NullPartitionResult& sorted, ValueSelector&&
value_selector,
+ IsNullSelector&& is_null_selector) {
using T = decltype(value_selector(int64_t{}));
Review Comment:
Idea: instead of specializing on `ArrowType`, we can just pass a
`is_null_selector` that always returns true for types without NaNs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
