nevi-me commented on a change in pull request #246:
URL: https://github.com/apache/arrow-rs/pull/246#discussion_r625505979
##########
File path: parquet/src/arrow/levels.rs
##########
@@ -311,11 +333,20 @@ impl LevelInfo {
} else if self.is_list {
// second exception, always increment after a list
self.max_definition + 1
+ } else if is_parent_struct && !self.is_nullable {
+ // if the parent is a non-null struct, don't increment
Review comment:
I checked this, trying to rely on the `!self.is_list` doesn't always
work, so I'm leaving the logic as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
