kou commented on code in PR #49439: URL: https://github.com/apache/arrow/pull/49439#discussion_r2915860970
########## cpp/src/gandiva/precompiled/string_ops.cc: ########## @@ -1966,6 +1966,22 @@ gdv_int32 evaluate_return_char_length(gdv_int32 text_len, gdv_int32 actual_text_ return return_char_length; } +// Fill a buffer with repeated fill_text using O(log n) doubling strategy +FORCE_INLINE +void fill_buffer_with_pattern(gdv_binary dest, gdv_int32 total_fill_bytes, Review Comment: Can we add `static` for internal function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
