justing-bq commented on code in PR #49267:
URL: https://github.com/apache/arrow/pull/49267#discussion_r2926436848
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/system_dsn.cc:
##########
@@ -55,7 +51,7 @@ void PostLastInstallerError() {
buf << L"Message: \"" << msg << L"\", Code: " << code;
std::wstring error_msg = buf.str();
- PostError(code, error_msg.c_str());
+ PostError(code, (LPWSTR)error_msg.c_str());
}
Review Comment:
Now using const_cast.
##########
cpp/src/arrow/flight/sql/odbc/tests/type_info_test.cc:
##########
@@ -1757,27 +1761,31 @@ TEST_F(TypeInfoOdbcV2MockTest,
TestSQLGetTypeInfoTimeODBCVer2) {
NULL, // expected_num_prec_radix
NULL); // expected_interval_prec
- CheckSQLDescribeColODBCVer2(this->stmt);
+ CheckSQLDescribeColODBCVer2(stmt);
// No more data
- ASSERT_EQ(SQL_NO_DATA, SQLFetch(this->stmt));
+ ASSERT_EQ(SQL_NO_DATA, SQLFetch(stmt));
}
-TEST_F(TypeInfoOdbcV2MockTest, TestSQLGetTypeInfoSQLTypeTimeODBCVer2) {
+TEST_F(TypeInfoOdbcV2MockTest, TestSQLGetTypeInfoSQLTypeTime) {
+#ifdef __APPLE__
+ ASSERT_EQ(SQL_SUCCESS, SQLGetTypeInfo(stmt, SQL_TYPE_DATE));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
