zeroshade commented on code in PR #4084:
URL: https://github.com/apache/arrow-adbc/pull/4084#discussion_r2927689843
##########
c/driver_manager/adbc_driver_manager_driver_loading.cc:
##########
@@ -279,7 +279,7 @@ SearchPaths GetSearchPaths(const AdbcLoadFlags levels) {
if (levels & ADBC_LOAD_FLAG_SEARCH_USER) {
// Check the user configuration directory
- std::filesystem::path user_config_dir = InternalAdbcUserConfigDir();
+ std::filesystem::path user_config_dir = InternalAdbcUserConfigDir() /
"drivers";
Review Comment:
the capitalization has to change based on the system (linux and venvs get
"drivers" while Windows and mac get "Drivers")
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -1226,7 +1226,7 @@ TEST_F(DriverManifest, LoadUserLevelManifest) {
ADBC_LOAD_FLAG_DEFAULT, nullptr, &driver,
&error),
Not(IsOkStatus(&error)));
- auto user_config_dir = InternalAdbcUserConfigDir();
+ auto user_config_dir = InternalAdbcUserConfigDir() / "drivers";
Review Comment:
same comment as above, some systems get "Drivers" instead of "drivers"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
