rok commented on PR #48622: URL: https://github.com/apache/arrow/pull/48622#issuecomment-4054994878
> Thanks for the ping @rok Yeah I will try my best to review this week. Perfect! Looking forward :). > 1. Are you just looking for a review of: > > * [`_stubs_typing.pyi`](https://github.com/apache/arrow/pull/48622/files#diff-c5785163a5f2f9960c4b1d90d2fdc8652e137433af5d88d8a3819a613c4a1b79) > * [`_types.pyi`](https://github.com/apache/arrow/pull/48622/files#diff-9558daf1f32eda5aedc71762fbc38dc60a18634dfb05d7c77f8911e1d25537e0) > * [`error.pyi`](https://github.com/apache/arrow/pull/48622/files#diff-83c40a21fb6ef9b823e58c402b7c67637dccfe382c49342ead56bdcb45424021) Yes, these are the meaningful files! I've also rebased so CMake changes are no longer polluting the PR. > 2. Have you considered using [Ruff](https://docs.astral.sh/ruff/) to help with the stubs? I remember looking into pyi linter at some point and I forget what the outcome was. Definitely a good idea to have it here. I'll try to include it here or at least run it through the .pyi files of the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
