kentkwu commented on PR #4091: URL: https://github.com/apache/arrow-adbc/pull/4091#issuecomment-4057295371
> the idea is sound and makes sense to me. just curious on the params and whether we should allow streaming the params as well, particularly useful for bulk_ingest support I think the simplest API surface is to just take `query(sql: string, params?: Table)` and treat the streaming bulk ingest as a separate use case. Inclined to keep the main `query` method (since it will be by far the most used) minimal, and we can relax it if it's not working for some people. There is additional work for streaming/bulk ingest that's required here, however it's out of scope for this particular change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
