lidavidm commented on code in PR #4057:
URL: https://github.com/apache/arrow-adbc/pull/4057#discussion_r2935234912
##########
c/driver/postgresql/validation/queries/type/bind/time_ms.txtcase:
##########
@@ -16,6 +16,24 @@
// under the License.
-// part: metadata
+// part: expected_schema
-skip = "COPY Writer not implemented"
+{
+ "format": "+s",
+ "children": [
+ {
+ "name": "value",
+ "format": "ttm",
Review Comment:
I expect you will need microseconds here and below
##########
c/driver/postgresql/validation/queries/ingest/time_ms.txtcase:
##########
@@ -16,6 +16,29 @@
// under the License.
-// part: metadata
+// part: expected_schema
-skip = "COPY Writer not implemented"
+{
+ "format": "+s",
+ "children": [
+ {
+ "name": "idx",
+ "format": "l",
+ "flags": ["nullable"]
+ },
+ {
+ "name": "value",
+ "format": "ttm",
Review Comment:
```suggestion
"format": "ttu",
```
We always read microseconds, so let's expect microseconds (also the values
below need to be adjusted)
##########
c/driver/postgresql/validation/queries/type/bind/time_ms.txtcase:
##########
@@ -16,6 +16,24 @@
// under the License.
-// part: metadata
+// part: expected_schema
-skip = "COPY Writer not implemented"
+{
+ "format": "+s",
+ "children": [
+ {
+ "name": "value",
Review Comment:
Field name should be "res"
##########
c/driver/postgresql/validation/queries/ingest/time_us.txtcase:
##########
@@ -0,0 +1,44 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+// part: expected_schema
+
+{
+ "format": "+s",
+ "children": [
+ {
+ "name": "idx",
+ "format": "l",
+ "flags": ["nullable"]
+ },
+ {
+ "name": "value",
+ "format": "ttu",
+ "flags": ["nullable"]
+ }
+ ]
+}
+
+// part: expected
+
+{"idx": 0, "value": null}
+{"idx": 1, "value": 0}
+{"idx": 2, "value": 1}
+{"idx": 3, "value": 3723123456}
+{"idx": 4, "value": 86399999999}
+{"idx": 5, "value": 86400000000}
Review Comment:
It appears these values do not line up with what's expected
(https://github.com/adbc-drivers/validation/blob/main/adbc_drivers_validation/queries/ingest/time_us.txtcase)
Frankly there should be no need to override this case?
##########
c/driver/postgresql/validation/queries/ingest/time_ms.txtcase:
##########
@@ -16,6 +16,29 @@
// under the License.
-// part: metadata
+// part: expected_schema
-skip = "COPY Writer not implemented"
+{
+ "format": "+s",
+ "children": [
+ {
+ "name": "idx",
+ "format": "l",
+ "flags": ["nullable"]
+ },
+ {
+ "name": "value",
+ "format": "ttm",
Review Comment:
You may want to refer to
https://github.com/adbc-drivers/validation/blob/main/adbc_drivers_validation/queries/ingest/time_us.txtcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
