Dandandan commented on code in PR #9511:
URL: https://github.com/apache/arrow-rs/pull/9511#discussion_r2944836025
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -171,11 +173,89 @@ impl BooleanArray {
}
}
- /// Returns the number of non null, false values within this array
+ /// Returns the number of non null, false values within this array.
+ /// If you only need to check if there is at least one false value,
consider using `has_false()` which can short-circuit and be more efficient.
pub fn false_count(&self) -> usize {
self.len() - self.null_count() - self.true_count()
}
+ /// Returns whether there is at least one non-null `true` value in this
array.
+ ///
+ /// This is more efficient than `true_count() > 0` because it can
short-circuit
+ /// as soon as a `true` value is found, without counting all set bits.
+ ///
+ /// Null values are not counted as `true`. Returns `false` for empty
arrays.
+ pub fn has_true(&self) -> bool {
+ match self.nulls() {
+ Some(nulls) => {
+ let null_chunks = nulls.inner().bit_chunks().iter_padded();
+ let value_chunks = self.values().bit_chunks().iter_padded();
+ null_chunks.zip(value_chunks).any(|(n, v)| (n & v) != 0)
+ }
+ None => {
+ let bit_chunks = UnalignedBitChunk::new(
Review Comment:
Shouldn't you be able to use `BitChunkIterator` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
