Dandandan commented on code in PR #9574:
URL: https://github.com/apache/arrow-rs/pull/9574#discussion_r2958349157
##########
parquet/tests/arrow_reader/io/async_reader.rs:
##########
@@ -275,9 +275,7 @@ async fn test_read_multiple_row_filter() {
"Read Multi:",
" Row Group 1, column 'a': MultiPage(dictionary_page: true,
data_pages: [0, 1]) (1856 bytes, 1 requests) [data]",
"Read Multi:",
- " Row Group 1, column 'b': DictionaryPage (1617 bytes, 1
requests) [data]",
- " Row Group 1, column 'b': DataPage(0) (113 bytes , 1
requests) [data]",
- " Row Group 1, column 'b': DataPage(1) (126 bytes , 1
requests) [data]",
+ " Row Group 1, column 'b': MultiPage(dictionary_page: true,
data_pages: [0, 1]) (1856 bytes, 1 requests) [data]",
Review Comment:
Was a bit surprised to see this changed (it's more optimal).
Seems when all values pass it creates 3 requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
