jorisvandenbossche commented on pull request #9948:
URL: https://github.com/apache/arrow/pull/9948#issuecomment-832138776


   The inference logic itself actually became simpler with the current state of 
the PR, IMO ;) (only the update-logic for combining multiple inferred types got 
a bit more complicated, but that's the necessary bug fix)
   
   Now, whether to interpret `Decimal('123e2')` as `decimal128(5, 0)` or 
`decimal128(3, -2)`: this PR changes that to `(3, -2)`, but there might also be 
some arguments to not use negative scales by default in case of ambiguity. Many 
SQL engines don't actually support negative scales, and also Parquet requires 
the scale to be 0 or a positive integer < precision 
(https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal). 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to