wgtmac commented on code in PR #49334:
URL: https://github.com/apache/arrow/pull/49334#discussion_r2964699706
##########
cpp/src/parquet/bloom_filter_reader.cc:
##########
@@ -76,10 +83,39 @@ std::unique_ptr<BloomFilter>
RowGroupBloomFilterReaderImpl::GetColumnBloomFilter
"bloom filter length + bloom filter offset greater than file size");
}
}
- auto stream = ::arrow::io::RandomAccessFile::GetStream(
- input_, *bloom_filter_offset, file_size - *bloom_filter_offset);
+ std::unique_ptr<ColumnCryptoMetaData> crypto_metadata =
col_chunk->crypto_metadata();
+ std::unique_ptr<Decryptor> header_decryptor =
+
InternalFileDecryptor::GetColumnMetaDecryptorFactory(file_decryptor_.get(),
+
crypto_metadata.get())();
+ std::unique_ptr<Decryptor> bitset_decryptor =
+
InternalFileDecryptor::GetColumnDataDecryptorFactory(file_decryptor_.get(),
Review Comment:
Ah, hold on. Per the spec, `all modules except pages are encrypted with the
GCM cipher`. We should just use meta decryptor for both bloom filter header and
bitset. See:
https://github.com/apache/parquet-format/blob/285b6fd1335da2e8bafe8570f0c00b55c2c41748/Encryption.md?plain=1#L164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
