alamb commented on code in PR #9470:
URL: https://github.com/apache/arrow-rs/pull/9470#discussion_r2961947027
##########
arrow-schema/src/field.rs:
##########
@@ -30,6 +30,9 @@ use crate::{
extension::{EXTENSION_TYPE_METADATA_KEY, EXTENSION_TYPE_NAME_KEY,
ExtensionType},
};
+/// The metadata key for the Parquet field id of a [`Field`].
Review Comment:
My one concern is that this now has a parquet specific implementation detail
in the arrow crate 🤔
The dependency until now has been the other way around.
Maybe we could add this function as a `ParquetFieldExt` trait in the Parquet
crate so we could keep the parquet specific logic in that crate rather than in
arrow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
