ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r626007776
##########
File path: r/R/dplyr.R
##########
@@ -540,6 +542,31 @@ arrow_stringr_string_replace_function <- function(FUN,
max_replacements) {
}
}
+arrow_r_string_split_function <- function(FUN, reverse = FALSE, max_splits =
-1){
+ function(x, split, fixed = FALSE, perl = FALSE, useBytes = FALSE){
+
+ assert_that(length(split) == 1)
+
+ # if !fixed but no regex metachars in split pattern, allow to proceed as
split isn't regex
+ if(!fixed && contains_regex(split)){
+ stop("regular expression matching not supported in strsplit for Arrow",
call. = FALSE)
Review comment:
Also good to add parens after the function name, for clarity. The
tidyverse style guide is big into always using parens after function names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
