CurtHagenlocher commented on code in PR #291:
URL: https://github.com/apache/arrow-dotnet/pull/291#discussion_r2971775255
##########
src/Apache.Arrow/Arrays/ArrayData.cs:
##########
@@ -149,6 +204,44 @@ public ArrayData Slice(int offset, int length)
return new ArrayData(DataType, length, nullCount, offset, Buffers,
Children, Dictionary);
}
Review Comment:
Point taken about the lack of broader support for `SliceShared`, but
changing the contract around `Slice` is a breaking change. I think the best we
can do is to support `SliceShared` everywhere and then eventually mark `Slice`
as obsolete -- perhaps eventually removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
