liamzwbao commented on PR #9497: URL: https://github.com/apache/arrow-rs/pull/9497#issuecomment-4106950401
Hi @alamb, based on benchmarking, this change still introduces a regression for short lists but performs well for long lists. The likely culprit is the `make_array() + into_data()` round-trip. The current `decode()` interface returns `ArrayData`, so we have to convert the child `ArrayData` into `ArrayRef` (via make_array) to pass it to `GenericListArray::try_new()`, then convert the result back to `ArrayData` (via into_data()). I'm going to experiment with changing the decode interface to return typed arrays directly, which would eliminate this round-trip. I'll follow up once that PR is ready, and we can revisit this one afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
