AntoinePrv commented on code in PR #49580: URL: https://github.com/apache/arrow/pull/49580#discussion_r2975726044
########## cpp/src/arrow/util/bpacking_simd_kernel_internal.h: ########## @@ -237,7 +240,8 @@ auto right_shift_by_excess(const xsimd::batch<Int, Arch>& batch, constexpr auto IntSize = sizeof(Int); // Architecture for which there is no variable right shift but a larger fallback exists. - /// TODO(xsimd) Tracking for Avx2 in https://github.com/xtensor-stack/xsimd/pull/1220 + // TODO(xsimd) Tracking for Avx2 in https://github.com/xtensor-stack/xsimd/pull/1220 Review Comment: We still need to keep it because some builds use a version of xsimd that does not yet have the fix. > Do we need `#if ...` for this too? Contrary to the fix in this PR, in this case the back-ported fix also works with newer xsimd versions, so we don't really need to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
