CurtHagenlocher commented on code in PR #4134:
URL: https://github.com/apache/arrow-adbc/pull/4134#discussion_r2981964779
##########
csharp/src/Client/AdbcDataReader.cs:
##########
@@ -308,22 +306,18 @@ public override bool IsDBNull(int ordinal)
public override bool NextResult()
{
- this.recordBatch = ReadNextRecordBatchAsync().Result;
-
- if (this.recordBatch != null)
- {
- return true;
- }
-
return false;
}
protected override void Dispose(bool disposing)
{
if (disposing)
{
+ this.adbcQueryResult.Stream?.Dispose();
+ this.adbcQueryResult.Stream = null;
Review Comment:
Oops, these should be reordered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
