sdf-jkl commented on PR #9599: URL: https://github.com/apache/arrow-rs/pull/9599#issuecomment-4120843812
> As I try to refresh my memories of how this is all supposed to work, I realize there aren't many unit tests for the top-level and object field cases -- at least not visible in the PR diff. Even tho there is a behavior change for top-level field handling. > > Do we have test gaps here? The only behavior change in this PR is `TopLevelVariant` handling in `VariantToShreddedArrayVariantRowBuilder::append_null`. I added a focused unit test to cover that path (`test_variant_get_list_like_unsafe_cast_preserves_null_elements`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
