wwarner-inf opened a new pull request, #726:
URL: https://github.com/apache/arrow-go/pull/726

   ### Rationale for this change
   
   Maps of Nullables produce corrupted parquet.
   
   ### What changes are included in this PR?
   
   The existing tests for `TakeKernelMap` are made runnable by correcting the 
test json to be suitable input for `array.FromJSON()`. Added a condition in 
`assertTakeArrays()` that checks that the data type has been preserved. Using 
the C++ implementation as a reference.
   
   ### Are these changes tested?
   Yes, but not deeply.
   
   ### Are there any user-facing changes?
   The api is unchanged, however parquet output will change slightly for those 
files containing maps with optional values.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to