jding-xyz commented on code in PR #149:
URL: https://github.com/apache/arrow-swift/pull/149#discussion_r2992850966
##########
Sources/Arrow/ArrowWriter.swift:
##########
@@ -341,7 +372,8 @@ public class ArrowWriter { // swiftlint:disable:this
type_body_length
public func writeStreaming(_ info: ArrowWriter.Info) -> Result<Data,
ArrowError> {
let writer: any DataWriter = InMemDataWriter()
switch toMessage(info.schema) {
- case .success(let schemaData):
+ case .success(var schemaData):
+ addPadForAlignment(&schemaData)
withUnsafeBytes(of: CONTINUATIONMARKER.littleEndian)
{writer.append(Data($0))}
withUnsafeBytes(of: UInt32(schemaData.count).littleEndian)
{writer.append(Data($0))}
writer.append(schemaData)
Review Comment:
Added testStreamingSchemaMetadataPadding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
