asubiotto commented on code in PR #9621:
URL: https://github.com/apache/arrow-rs/pull/9621#discussion_r3000918237
##########
arrow-ord/src/cmp.rs:
##########
@@ -327,28 +336,41 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum)
-> Result<BooleanArray,
}
/// Perform a potentially vectored `op` on the provided `ArrayOrd`
+#[allow(clippy::too_many_arguments)]
fn apply<T: ArrayOrd>(
op: Op,
l: T,
l_s: bool,
Review Comment:
I don't think that's right. Scalars can have ree and/or dictionary types and
l_v and l_ree are both Some for Ree<Dict>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
